Details
- Reviewers
epriestley chad - Maniphest Tasks
- T4553: When re-prioritizing a task on a workboard, it should change position in the column if appropos
T4407: Boards need some quick-add task functionality - Commits
- Restricted Diffusion Commit
rPd08576ed4e99: Workboards - add task create + improve task placement wrt priority edits
created tasks and they showed up in the proper column. edited task priority and they moved about sensically.
Diff Detail
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Nice, this looks about as reasonable as we're likely to get to me.
| src/applications/project/controller/PhabricatorProjectBoardController.php | ||
|---|---|---|
| 149 | Maybe put this in the header? Currently, there's some hard-coded edit stuff inside PHUIWorkpanelView, but I think that should be like addAction(...) or something, and then we should just add the "add" and "edit" actions as applicable. (Generally, the footer isn't always easily accessible right now because columns can have varied heights.) Not sure if @chad has opinions on this. This is trivial to mess with later, in any case. | |
How much more work would we need to have a message sent to a board page for each task associated with the board once it was updated? It would be cool to have live updates I think.
| src/applications/project/controller/PhabricatorProjectBoardController.php | ||
|---|---|---|
| 149 | @chad did have a verbal preference of having it in the header but the mock image had it in the bottom. I'll put it in the header | |
P1081 was my brief effort at doing that if it's helpful -- then I realized I'd have to do this diff and gave up. :P
I think we reasonably look into live update stuff once Aphlict gets the fixes for Conpherence. One issue is that it would expose us to a bunch of races -- like if the server has "ABCD" and applies "A after B", then "D after A" in that order, it will end up with "BADC". If the client receives them out of order, it would get "DBAC".
We could fix this by, e.g., putting a logical clock / version number on the column, and sending back a "version" and all of the PHIDs in the column in order, and then the client just fixes the order to be correct if it gets a message with a larger version. But this would limit our ability to, e.g., animate it nicely.
- make it a "plus" in the header instead
- some code to support that in the View class
- fix a bug on default column, where we need to pull all the project tasks as "no col" means "default col". make this a separate code path since its much beefier in terms of data pulling.