Page MenuHomePhabricator

Implement more Differential fields on ApplicationTransaction/CustomField
ClosedPublic

Authored by epriestley on Feb 26 2014, 11:31 PM.
Tags
None
Referenced Files
F13325020: D8357.diff
Sat, Jun 15, 1:15 AM
F13313384: D8357.diff
Tue, Jun 11, 7:49 AM
F13300251: D8357.diff
Fri, Jun 7, 8:59 AM
F13261769: D8357.diff
Mon, May 27, 1:25 AM
F13250642: D8357.id.diff
Fri, May 24, 3:57 PM
F13245685: D8357.diff
Thu, May 23, 6:10 AM
F13225370: D8357.diff
Sun, May 19, 2:55 PM
F13208140: D8357.id19868.diff
May 16 2024, 9:41 AM
Subscribers

Details

Summary

Ref T2222. Ref T3886. Gets the storage-based fields working.

This requires future changes to actually do anything, all this code is inactive.

Test Plan

{F118863}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

How come the stored fields have a "phabricator" prefix while the non-stored fields have a "differential" prefix?

src/applications/differential/storage/DifferentialRevision.php
76–79

woot woot

src/infrastructure/customfield/field/PhabricatorCustomFieldList.php
202

spacing derp

The prefixes are so that we still access the same migrated data. We could fairly easily re-migrate the data at some point to normalize the prefixes, but it doesn't seem like a big deal to keep it this way.

src/infrastructure/customfield/field/PhabricatorCustomFieldList.php
202

whoops

epriestley updated this revision to Unknown Object (????).Feb 27 2014, 12:53 AM
  • Fix $icon spacing.