Page MenuHomePhabricator

Implement more Differential fields on ApplicationTransaction/CustomField
ClosedPublic

Authored by epriestley on Feb 26 2014, 11:31 PM.
Tags
None
Referenced Files
F14360909: D8357.id19869.diff
Fri, Dec 20, 10:50 AM
F14360794: D8357.id19865.diff
Fri, Dec 20, 10:44 AM
F14357304: D8357.diff
Fri, Dec 20, 3:52 AM
Unknown Object (File)
Tue, Dec 17, 11:13 AM
Unknown Object (File)
Wed, Dec 11, 6:18 PM
Unknown Object (File)
Tue, Dec 10, 7:01 PM
Unknown Object (File)
Sun, Dec 8, 7:45 AM
Unknown Object (File)
Fri, Dec 6, 1:20 PM
Subscribers

Details

Summary

Ref T2222. Ref T3886. Gets the storage-based fields working.

This requires future changes to actually do anything, all this code is inactive.

Test Plan

{F118863}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

How come the stored fields have a "phabricator" prefix while the non-stored fields have a "differential" prefix?

src/applications/differential/storage/DifferentialRevision.php
76–79

woot woot

src/infrastructure/customfield/field/PhabricatorCustomFieldList.php
202

spacing derp

The prefixes are so that we still access the same migrated data. We could fairly easily re-migrate the data at some point to normalize the prefixes, but it doesn't seem like a big deal to keep it this way.

src/infrastructure/customfield/field/PhabricatorCustomFieldList.php
202

whoops

epriestley updated this revision to Unknown Object (????).Feb 27 2014, 12:53 AM
  • Fix $icon spacing.