Page MenuHomePhabricator

Implement more Differential fields on ApplicationTransaction/CustomField
ClosedPublic

Authored by epriestley on Feb 26 2014, 11:31 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 9:29 AM
Unknown Object (File)
Sun, Apr 28, 5:27 AM
Unknown Object (File)
Sun, Apr 28, 5:26 AM
Unknown Object (File)
Sun, Apr 28, 5:26 AM
Unknown Object (File)
Sun, Apr 28, 5:26 AM
Unknown Object (File)
Sun, Apr 28, 4:23 AM
Unknown Object (File)
Thu, Apr 25, 3:00 AM
Unknown Object (File)
Sat, Apr 20, 6:31 PM
Subscribers

Details

Summary

Ref T2222. Ref T3886. Gets the storage-based fields working.

This requires future changes to actually do anything, all this code is inactive.

Test Plan

{F118863}

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

How come the stored fields have a "phabricator" prefix while the non-stored fields have a "differential" prefix?

src/applications/differential/storage/DifferentialRevision.php
76–79

woot woot

src/infrastructure/customfield/field/PhabricatorCustomFieldList.php
202

spacing derp

The prefixes are so that we still access the same migrated data. We could fairly easily re-migrate the data at some point to normalize the prefixes, but it doesn't seem like a big deal to keep it this way.

src/infrastructure/customfield/field/PhabricatorCustomFieldList.php
202

whoops

epriestley updated this revision to Unknown Object (????).Feb 27 2014, 12:53 AM
  • Fix $icon spacing.