Page MenuHomePhabricator

Implement more Differential fields on ApplicationTransaction/CustomField
ClosedPublic

Authored by epriestley on Feb 26 2014, 11:31 PM.
Tags
None
Referenced Files
F19822566: D8357.diff
Sat, Mar 7, 6:34 AM
F19818767: D8357.id19869.diff
Fri, Mar 6, 12:06 AM
F19818766: D8357.id19869.diff
Fri, Mar 6, 12:06 AM
F19815713: D8357.id.diff
Thu, Mar 5, 12:09 AM
F19810895: D8357.id19868.diff
Tue, Mar 3, 9:34 PM
F19787265: D8357.id19869.diff
Wed, Feb 25, 1:30 PM
F19587274: D8357.id19869.diff
Feb 2 2026, 7:11 AM
F19540740: D8357.diff
Jan 22 2026, 12:06 AM
Subscribers

Details

Summary

Ref T2222. Ref T3886. Gets the storage-based fields working.

This requires future changes to actually do anything, all this code is inactive.

Test Plan

{F118863}

Diff Detail

Repository
rP Phabricator
Branch
dfield2
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

How come the stored fields have a "phabricator" prefix while the non-stored fields have a "differential" prefix?

src/applications/differential/storage/DifferentialRevision.php
76–79

woot woot

src/infrastructure/customfield/field/PhabricatorCustomFieldList.php
202

spacing derp

The prefixes are so that we still access the same migrated data. We could fairly easily re-migrate the data at some point to normalize the prefixes, but it doesn't seem like a big deal to keep it this way.

src/infrastructure/customfield/field/PhabricatorCustomFieldList.php
202

whoops

epriestley updated this revision to Unknown Object (????).Feb 27 2014, 12:53 AM
  • Fix $icon spacing.