The intent of getOrBuildEngine() is to save some boilerplate in cases where we're just using a standard engine, but it didn't get cached so we'd rebuilt it over and over again.
This was especially bad in Differential with a large number of inlines.
Details
Details
- Reviewers
btrahan dctrwatson - Commits
- Restricted Diffusion Commit
rP7ff211065555: Stop markup cache from hitting cache O(N^2) times
"Query" tab of services is no longer quite so ridiculous in Differential.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- mcache
- Lint
Lint Passed - Unit
Tests Passed