Page MenuHomePhabricator

Stop markup cache from hitting cache O(N^2) times
ClosedPublic

Authored by epriestley on Feb 26 2014, 7:59 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, May 3, 2:33 AM
Unknown Object (File)
Mon, Apr 29, 2:01 PM
Unknown Object (File)
Sun, Apr 28, 5:25 AM
Unknown Object (File)
Sun, Apr 28, 5:25 AM
Unknown Object (File)
Sun, Apr 28, 5:25 AM
Unknown Object (File)
Sun, Apr 28, 5:25 AM
Unknown Object (File)
Sat, Apr 27, 12:01 PM
Unknown Object (File)
Wed, Apr 24, 9:54 PM
Subscribers

Details

Summary

The intent of getOrBuildEngine() is to save some boilerplate in cases where we're just using a standard engine, but it didn't get cached so we'd rebuilt it over and over again.

This was especially bad in Differential with a large number of inlines.

Test Plan

"Query" tab of services is no longer quite so ridiculous in Differential.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped