Page MenuHomePhabricator

Implement Accept/Reject in ApplicationTransactions, approximately
ClosedPublic

Authored by epriestley on Feb 25 2014, 4:16 AM.
Tags
None
Referenced Files
F14899254: D8333.id19830.diff
Sun, Feb 9, 11:38 AM
F14899253: D8333.id19813.diff
Sun, Feb 9, 11:38 AM
F14899252: D8333.id.diff
Sun, Feb 9, 11:38 AM
F14899251: D8333.diff
Sun, Feb 9, 11:38 AM
Unknown Object (File)
Sat, Feb 8, 11:46 PM
Unknown Object (File)
Fri, Feb 7, 5:20 PM
Unknown Object (File)
Fri, Jan 31, 6:09 AM
Unknown Object (File)
Tue, Jan 28, 6:32 AM
Subscribers

Details

Summary

Ref T2222. This mostly makes Accept/Reject work. The big missing piece is that overall revision status does not yet update properly. I need to think about how I want that to work a little bit more.

Test Plan

Accepted and rejected some stuff.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

snihalani added a subscriber: snihalani.
snihalani added inline comments.
src/applications/differential/editor/DifferentialTransactionEditor.php
97

Should this be $will_add_reviewer instead?

snihalani edited edge metadata.

gonna remove the reviewer who accepted the revision who this review gets out of closed state.