Ref T2222. This mostly makes Accept/Reject work. The big missing piece is that overall revision status does not yet update properly. I need to think about how I want that to work a little bit more.
Details
Details
- Reviewers
snihalani btrahan - Maniphest Tasks
- T2222: Implement ApplicationTransactions in Differential
- Commits
- Restricted Diffusion Commit
rPca8c2c2d11a3: Implement Accept/Reject in ApplicationTransactions, approximately
Accepted and rejected some stuff.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Branch
- dxpfield4
- Lint
Lint Passed Severity Location Code Message Advice src/applications/differential/editor/DifferentialTransactionEditor.php:148 XHP16 TODO Comment Advice src/applications/differential/editor/DifferentialTransactionEditor.php:198 XHP16 TODO Comment - Unit
Tests Passed
Event Timeline
| src/applications/differential/editor/DifferentialTransactionEditor.php | ||
|---|---|---|
| 97 | Should this be $will_add_reviewer instead? | |
Comment Actions
gonna remove the reviewer who accepted the revision who this review gets out of closed state.