Page MenuHomePhabricator

Remove "supportsStateParameter()" from generic OAuth2 code
ClosedPublic

Authored by epriestley on Feb 23 2014, 11:23 PM.
Tags
None
Referenced Files
F15413706: D8319.id19784.diff
Wed, Mar 19, 8:44 PM
F15402928: D8319.id.diff
Tue, Mar 18, 1:06 AM
F15399601: D8319.diff
Mon, Mar 17, 5:45 AM
F15381437: D8319.id19784.diff
Fri, Mar 14, 7:39 AM
Unknown Object (File)
Mon, Feb 24, 11:31 AM
Unknown Object (File)
Feb 16 2025, 12:25 AM
Unknown Object (File)
Feb 9 2025, 11:37 AM
Unknown Object (File)
Feb 9 2025, 11:37 AM
Subscribers

Details

Summary

Depends on D8318. All providers must support this, or they can't be implemented securely. This is based on a very old reading of the GitHub instructions or something like that which didn't mention "state", but the provider supports it.

This has no impact at runtime because no provider has ever returned false from this method, nor would we ever implement a provider that did.

Test Plan

Grepped for callsites.

Diff Detail

Repository
rPHU libphutil
Branch
poauth
Lint
Lint Passed
Unit
No Test Coverage