Page MenuHomePhabricator

Remove "supportsStateParameter()" from generic OAuth2 code
ClosedPublic

Authored by epriestley on Feb 23 2014, 11:23 PM.
Tags
None
Referenced Files
F19933100: D8319.diff
Fri, Apr 10, 10:14 PM
F19895014: D8319.id.diff
Sat, Mar 28, 6:20 PM
F19810600: D8319.diff
Mar 3 2026, 8:36 PM
F19722329: D8319.id.diff
Feb 13 2026, 3:05 AM
F19661249: D8319.id.diff
Feb 7 2026, 6:14 AM
F19661247: D8319.id.diff
Feb 7 2026, 6:13 AM
F19508734: D8319.id.diff
Jan 10 2026, 9:30 AM
F19507623: D8319.id.diff
Jan 9 2026, 10:20 PM
Subscribers

Details

Summary

Depends on D8318. All providers must support this, or they can't be implemented securely. This is based on a very old reading of the GitHub instructions or something like that which didn't mention "state", but the provider supports it.

This has no impact at runtime because no provider has ever returned false from this method, nor would we ever implement a provider that did.

Test Plan

Grepped for callsites.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped