HomePhabricator

Remove "supportsStateParameter()" from generic OAuth2 code

Description

Remove "supportsStateParameter()" from generic OAuth2 code

Summary:
Depends on D8318. All providers must support this, or they can't be implemented securely. This is based on a very old reading of the GitHub instructions or something like that which didn't mention "state", but the provider supports it.

This has no impact at runtime because no provider has ever returned false from this method, nor would we ever implement a provider that did.

Test Plan: Grepped for callsites.

Reviewers: btrahan, arice

Reviewed By: arice

CC: chad, arice, aran

Differential Revision: https://secure.phabricator.com/D8319

Details

Provenance
epriestleyAuthored on
epriestleyPushed on Feb 24 2014, 12:46 AM
Reviewer
arice
Differential Revision
D8319: Remove "supportsStateParameter()" from generic OAuth2 code
Parents
rPHU5a9002ebed4f: Change "%s" in qsprintf to exclude non-BMP characters
Branches
Unknown
Tags
Unknown