Differential D8201

Write one DifferentialComment per CommentEditor action
ClosedPublic
Actions

Authored by epriestley on Feb 11 2014, 10:55 PM.

Details

Reviewers

btrahan

Maniphest Tasks

T2222: Implement ApplicationTransactions in Differential

Commits

Restricted Diffusion Commit
rP1dbfc56d3588: Write one DifferentialComment per CommentEditor action

Summary

See D8200. Ref T2222. Instead of writing one comment which can have a ton of different effects, write a series of one-effect comments. These will be easier to convert into ApplicationTransactions.

This has a minor user-facing effect of making these multiple-action comments render separately:

{F111919}

Once the migration completes, they should automatically merge together nicely again.

Test Plan

Made a bunch of comments and took a bunch of actions, all of which worked normally except that they rendered as several things instead of just one.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

Facebook: See inline. This return value is not used anywhere in Phabricator, but might be used by the hacked-up XMail setup. There is no longer a meaningful single value to return, because one action can generate several transactions.