Page MenuHomePhabricator

Remove PhabricatorProjectEditor
ClosedPublic

Authored by epriestley on Feb 8 2014, 12:25 AM.
Tags
None
Referenced Files
F13336589: D8168.diff
Wed, Jun 19, 6:11 AM
F13332978: D8168.diff
Mon, Jun 17, 10:52 PM
F13322086: D8168.diff
Fri, Jun 14, 7:34 AM
F13293756: D8168.id18518.diff
Wed, Jun 5, 12:28 PM
F13286785: D8168.diff
Tue, Jun 4, 7:40 AM
F13283527: D8168.id18518.diff
Sun, Jun 2, 3:43 PM
F13273723: D8168.diff
Fri, May 31, 2:31 AM
F13234468: D8168.diff
May 21 2024, 3:26 AM
Subscribers

Details

Summary

Ref T4379. Perform all editing with modern transaction infrastructure. A few practical changes here:

  • Message for "project name required" should be a little nicer. I'll deal with this once more stuff gets straightened out. You get a reasonable message now, it's just not nicely handled as part of the form.
  • Message for "project name is not unique" should be a little nicer. Same as above.
  • Previously, we would automatically archive a project when the last member left or was removed. I'll probably restore this in a bit but am omitting it for the moment for simplicity.
  • Previously, we would create projects with goofy nonsensical permissions. Now we create them with reasonable permissions.
Test Plan
  • Created project.
  • Edited project.
  • Ran unit tests.
  • Viewed project edit history.

Diff Detail

Repository
rP Phabricator
Branch
projsub4
Lint
Lint Passed
Unit
Tests Passed