Page MenuHomePhabricator

Remove PhabricatorProjectEditor
ClosedPublic

Authored by epriestley on Feb 8 2014, 12:25 AM.
Tags
None
Referenced Files
F13234468: D8168.diff
Tue, May 21, 3:26 AM
F13223747: D8168.id18518.diff
Sun, May 19, 4:53 AM
F13212448: D8168.diff
Fri, May 17, 6:43 AM
F13195179: D8168.diff
Sun, May 12, 10:11 PM
F13183603: D8168.id18518.diff
Fri, May 10, 10:34 AM
F13183602: D8168.id18479.diff
Fri, May 10, 10:33 AM
F13183275: D8168.id.diff
Fri, May 10, 8:05 AM
F13183227: D8168.diff
Fri, May 10, 7:39 AM
Subscribers

Details

Summary

Ref T4379. Perform all editing with modern transaction infrastructure. A few practical changes here:

  • Message for "project name required" should be a little nicer. I'll deal with this once more stuff gets straightened out. You get a reasonable message now, it's just not nicely handled as part of the form.
  • Message for "project name is not unique" should be a little nicer. Same as above.
  • Previously, we would automatically archive a project when the last member left or was removed. I'll probably restore this in a bit but am omitting it for the moment for simplicity.
  • Previously, we would create projects with goofy nonsensical permissions. Now we create them with reasonable permissions.
Test Plan
  • Created project.
  • Edited project.
  • Ran unit tests.
  • Viewed project edit history.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped