When repairing Git remote URIs, include credentials
ClosedPublic
Actions

Authored by epriestley on Jan 24 2014, 1:22 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Jan 2, 5:48 AM

	Unknown Object (File)
	Mon, Dec 30, 9:29 AM

	Unknown Object (File)
	Sat, Dec 21, 2:49 AM

	Unknown Object (File)
	Dec 15 2024, 5:26 PM

	Unknown Object (File)
	Dec 13 2024, 7:36 AM

	Unknown Object (File)
	Dec 6 2024, 9:56 PM

	Unknown Object (File)
	Dec 6 2024, 6:44 AM

	Unknown Object (File)
	Nov 26 2024, 7:00 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rPc21a8d31dde2: When repairing Git remote URIs, include credentials

Summary

See IRC. Currently, if a fetch fails, we may repair the remote URI incorrectly, replacing it with one without any credentials. Instead, retain credentials.

Test Plan

Faked it locally, got le-boom to verify on IRC.

Diff Detail

Branch

remotecred

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

btrahan accepted this revision.Jan 24 2014, 1:22 AM

Closed by commit rPc21a8d31dde2 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

engine/

PhabricatorRepositoryPullEngine.php

6 lines

Diff 18223

View Options

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php

When repairing Git remote URIs, include credentialsClosedPublicActions