When repairing Git remote URIs, include credentials
ClosedPublic
Actions

Authored by epriestley on Jan 24 2014, 1:22 AM.

Tags

None

Referenced Files

	F15398214: D8055.id.diff
	Sun, Mar 16, 11:49 PM

	F15391893: D8055.id18224.diff
	Sat, Mar 15, 12:14 PM

	F15389777: D8055.id18223.diff
	Sat, Mar 15, 5:38 AM

	F15386880: D8055.diff
	Sat, Mar 15, 1:26 AM

	F15353672: D8055.id18224.diff
	Mon, Mar 10, 11:37 PM

	F15293709: D8055.diff
	Wed, Mar 5, 4:34 AM

	Unknown Object (File)
	Feb 16 2025, 5:42 AM

	Unknown Object (File)
	Feb 2 2025, 10:23 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rPc21a8d31dde2: When repairing Git remote URIs, include credentials

Summary

See IRC. Currently, if a fetch fails, we may repair the remote URI incorrectly, replacing it with one without any credentials. Instead, retain credentials.

Test Plan

Faked it locally, got le-boom to verify on IRC.

Diff Detail

Branch

remotecred

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

btrahan accepted this revision.Jan 24 2014, 1:22 AM

Closed by commit rPc21a8d31dde2 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

engine/

PhabricatorRepositoryPullEngine.php

6 lines

Diff 18223

View Options

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php

When repairing Git remote URIs, include credentialsClosedPublicActions