When repairing Git remote URIs, include credentials
ClosedPublic
Actions

Authored by epriestley on Jan 24 2014, 1:22 AM.

Tags

None

Referenced Files

	F19093213: D8055.id.diff
	Wed, Dec 3, 8:49 PM

	F19079900: D8055.id.diff
	Mon, Dec 1, 11:19 PM

	F18825608: D8055.id.diff
	Oct 23 2025, 10:59 PM

	F18818934: D8055.diff
	Oct 22 2025, 3:20 AM

	F18812377: D8055.diff
	Oct 20 2025, 8:53 AM

	F18811975: D8055.diff
	Oct 20 2025, 6:14 AM

	F18734570: D8055.id.diff
	Sep 30 2025, 10:56 PM

	F18625946: D8055.id.diff
	Sep 16 2025, 12:00 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rPc21a8d31dde2: When repairing Git remote URIs, include credentials

Summary

See IRC. Currently, if a fetch fails, we may repair the remote URI incorrectly, replacing it with one without any credentials. Instead, retain credentials.

Test Plan

Faked it locally, got le-boom to verify on IRC.

Diff Detail

Branch

remotecred

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

btrahan accepted this revision.Jan 24 2014, 1:22 AM

Closed by commit rPc21a8d31dde2 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

repository/

engine/

PhabricatorRepositoryPullEngine.php

6 lines

Diff 18223

View Options

src/applications/repository/engine/PhabricatorRepositoryPullEngine.php

When repairing Git remote URIs, include credentialsClosedPublicActions