Page MenuHomePhabricator
Differential D7952

Added test namespace field to `ArcanistUnitTestResult`
ClosedPublic
Actions

Authored by joshuaspence on Jan 13 2014, 8:31 PM.
Tags
None
Referenced Files
F15430379: D7952.id17989.diff
Mon, Mar 24, 7:23 AM
F15425894: D7952.id17990.diff
Sun, Mar 23, 6:34 AM
F15424747: D7952.diff
Sun, Mar 23, 12:13 AM
F15410898: D7952.diff
Wed, Mar 19, 8:40 AM
F15410859: D7952.diff
Wed, Mar 19, 8:35 AM
F15410842: D7952.diff
Wed, Mar 19, 8:32 AM
F15410820: D7952.diff
Wed, Mar 19, 8:29 AM
F15410799: D7952.diff
Wed, Mar 19, 8:26 AM
View All Files
Subscribers
aran
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCdd12b72f9a03: Added test namespace field to `ArcanistUnitTestResult`
Summary

See https://github.com/facebook/libphutil/issues/34

Test Plan

Run arc unit

Diff Detail

Branch
unit_test
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley accepted this revision.Jan 13 2014, 8:35 PM

Thanks!

src/unit/renderer/ArcanistUnitConsoleRenderer.php
18

If the namespace is empty, I think we should probably omit the ::, since otherwise everyone's stuff will become ::testname. I'll tweak that in the pull.

epriestley closed this revision.Jan 13 2014, 8:37 PM

Closed by commit rARCdd12b72f9a03 (authored by @joshuaspence, committed by @epriestley).

joshuaspence mentioned this in D11208: Export namespace in `ArcanistUnitTestResult` dictionary.Jan 4 2015, 11:57 AM
joshuaspence mentioned this in rARC9e6f876a68b4: Export namespace in `ArcanistUnitTestResult` dictionary.Jan 4 2015, 7:50 PM

Revision Contents
Changeset List

PathSize
src/
unit/
10 lines
engine/
phutil/
1 line
renderer/
2 lines

Diff 17989

View Options

src/unit/ArcanistUnitTestResult.php

Loading...
View Options

src/unit/engine/phutil/ArcanistPhutilTestCase.php

Loading...
View Options

src/unit/renderer/ArcanistUnitConsoleRenderer.php

Loading...
Phabricator · Built by Phacility