Page MenuHomePhabricator
Differential D7952

Added test namespace field to `ArcanistUnitTestResult`
ClosedPublic
Actions

Authored by joshuaspence on Jan 13 2014, 8:31 PM.
Tags
None
Referenced Files
F14018572: D7952.id.diff
Tue, Nov 5, 4:36 PM
F13993885: D7952.diff
Wed, Oct 23, 2:02 AM
F13963451: D7952.id17989.diff
Tue, Oct 15, 3:59 PM
Unknown Object (File)
Sat, Oct 12, 1:16 AM
Unknown Object (File)
Oct 9 2024, 8:54 PM
Unknown Object (File)
Oct 5 2024, 6:59 AM
Unknown Object (File)
Sep 21 2024, 2:44 PM
Unknown Object (File)
Sep 4 2024, 12:18 PM
View All Files
Subscribers
aran
epriestley
Korvin

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Commits
rARCdd12b72f9a03: Added test namespace field to `ArcanistUnitTestResult`
Summary

See https://github.com/facebook/libphutil/issues/34

Test Plan

Run arc unit

Diff Detail

Branch
unit_test
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley accepted this revision.Jan 13 2014, 8:35 PM

Thanks!

src/unit/renderer/ArcanistUnitConsoleRenderer.php
18

If the namespace is empty, I think we should probably omit the ::, since otherwise everyone's stuff will become ::testname. I'll tweak that in the pull.

epriestley closed this revision.Jan 13 2014, 8:37 PM

Closed by commit rARCdd12b72f9a03 (authored by @joshuaspence, committed by @epriestley).

joshuaspence mentioned this in D11208: Export namespace in `ArcanistUnitTestResult` dictionary.Jan 4 2015, 11:57 AM
joshuaspence mentioned this in rARC9e6f876a68b4: Export namespace in `ArcanistUnitTestResult` dictionary.Jan 4 2015, 7:50 PM

Revision Contents
Changeset List

PathSize
src/
unit/
10 lines
engine/
phutil/
1 line
renderer/
2 lines

Diff 17989

View Options

src/unit/ArcanistUnitTestResult.php

Loading...
View Options

src/unit/engine/phutil/ArcanistPhutilTestCase.php

Loading...
View Options

src/unit/renderer/ArcanistUnitConsoleRenderer.php

Loading...
Phabricator · Built by Phacility