Page MenuHomePhabricator

Fix two edge case issues with Differential mail tags
ClosedPublic

Authored by epriestley on Jan 9 2014, 1:53 AM.
Tags
None
Referenced Files
F19951692: D7912.diff
Sat, Apr 18, 1:46 PM
F19922503: D7912.diff
Mon, Apr 6, 6:46 PM
F19908508: D7912.id.diff
Wed, Apr 1, 7:51 PM
F19867837: D7912.id17909.diff
Mar 15 2026, 1:14 AM
F19625792: D7912.diff
Feb 4 2026, 7:10 PM
F19541459: D7912.id.diff
Jan 22 2026, 3:51 AM
F19233350: D7912.id17909.diff
Dec 21 2025, 5:39 PM
F18853330: D7912.id17926.diff
Oct 31 2025, 3:51 PM
Subscribers

Details

Summary

Via Asana. The tags on Differential mail are wrong in two cases:

  • Transactions which submit inline comments but no comment text are not labeled as "comments", but should be.
  • Non-close, non-comment transactions are not labeled at all, but should be labeled "other".
Test Plan

Submitted a no-comments, inlines-only transaction and got a message with proper X-Phabricator-Mail-Tags header.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped