Fix two edge case issues with Differential mail tags
ClosedPublic
Actions

Authored by epriestley on Jan 9 2014, 1:53 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, Apr 11, 10:18 AM

	Unknown Object (File)
	Sat, Apr 6, 3:56 PM

	Unknown Object (File)
	Sat, Apr 6, 3:56 PM

	Unknown Object (File)
	Sat, Apr 6, 3:04 PM

	Unknown Object (File)
	Sat, Apr 6, 2:42 PM

	Unknown Object (File)
	Sat, Apr 6, 5:42 AM

	Unknown Object (File)
	Fri, Mar 29, 6:06 AM

	Unknown Object (File)
	Feb 11 2024, 7:52 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP68de639470f0: Fix two edge case issues with Differential mail tags

Summary

Via Asana. The tags on Differential mail are wrong in two cases:

Transactions which submit inline comments but no comment text are not labeled as "comments", but should be.
Non-close, non-comment transactions are not labeled at all, but should be labeled "other".

Test Plan

Submitted a no-comments, inlines-only transaction and got a message with proper X-Phabricator-Mail-Tags header.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan accepted this revision.Jan 9 2014, 6:50 PM

Closed by commit rP68de639470f0 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

mail/

DifferentialCommentMail.php

9 lines

Diff 17926

View Options

src/applications/differential/mail/DifferentialCommentMail.php

Fix two edge case issues with Differential mail tagsClosedPublicActions