Fix two edge case issues with Differential mail tags
ClosedPublic
Actions

Authored by epriestley on Jan 9 2014, 1:53 AM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jun 6, 12:17 AM

	Unknown Object (File)
	Sat, May 31, 2:13 PM

	Unknown Object (File)
	Fri, May 30, 10:07 AM

	Unknown Object (File)
	Apr 29 2025, 10:10 AM

	Unknown Object (File)
	Apr 26 2025, 12:39 AM

	Unknown Object (File)
	Apr 20 2025, 7:14 PM

	Unknown Object (File)
	Apr 18 2025, 7:05 PM

	Unknown Object (File)
	Apr 12 2025, 5:48 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP68de639470f0: Fix two edge case issues with Differential mail tags

Summary

Via Asana. The tags on Differential mail are wrong in two cases:

Transactions which submit inline comments but no comment text are not labeled as "comments", but should be.
Non-close, non-comment transactions are not labeled at all, but should be labeled "other".

Test Plan

Submitted a no-comments, inlines-only transaction and got a message with proper X-Phabricator-Mail-Tags header.

Diff Detail

Branch

dxcommentmail

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

btrahan accepted this revision.Jan 9 2014, 6:50 PM

Closed by commit rP68de639470f0 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

mail/

DifferentialCommentMail.php

9 lines

Diff 17909

View Options

src/applications/differential/mail/DifferentialCommentMail.php

Fix two edge case issues with Differential mail tagsClosedPublicActions