Fix two edge case issues with Differential mail tags
ClosedPublic
Actions

Authored by epriestley on Jan 9 2014, 1:53 AM.

Tags

None

Referenced Files

	F13197304: D7912.diff
	Mon, May 13, 12:04 AM

	Unknown Object (File)
	Sat, May 4, 8:05 PM

	Unknown Object (File)
	Sat, May 4, 9:10 AM

	Unknown Object (File)
	Fri, May 3, 9:06 AM

	Unknown Object (File)
	Thu, May 2, 11:54 AM

	Unknown Object (File)
	Wed, Apr 24, 11:54 PM

	Unknown Object (File)
	Apr 11 2024, 10:18 AM

	Unknown Object (File)
	Apr 6 2024, 3:56 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP68de639470f0: Fix two edge case issues with Differential mail tags

Summary

Via Asana. The tags on Differential mail are wrong in two cases:

Transactions which submit inline comments but no comment text are not labeled as "comments", but should be.
Non-close, non-comment transactions are not labeled at all, but should be labeled "other".

Test Plan

Submitted a no-comments, inlines-only transaction and got a message with proper X-Phabricator-Mail-Tags header.

Diff Detail

Branch

dxcommentmail

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

btrahan accepted this revision.Jan 9 2014, 6:50 PM

Closed by commit rP68de639470f0 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

applications/

differential/

mail/

DifferentialCommentMail.php

9 lines

Diff 17909

View Options

src/applications/differential/mail/DifferentialCommentMail.php

Fix two edge case issues with Differential mail tagsClosedPublicActions