Page MenuHomePhabricator

Modernize Drydock CLI management of task execution
ClosedPublic

Authored by epriestley on Dec 26 2013, 9:03 PM.
Tags
None
Referenced Files
F15422610: D7835.id17747.diff
Sat, Mar 22, 9:46 AM
F15416922: D7835.id17747.diff
Thu, Mar 20, 2:23 PM
F15392820: D7835.id.diff
Sat, Mar 15, 5:46 PM
F15353135: D7835.id17747.diff
Mon, Mar 10, 8:08 PM
F15304122: D7835.id17747.diff
Thu, Mar 6, 1:25 AM
Unknown Object (File)
Mon, Feb 24, 11:21 AM
Unknown Object (File)
Mon, Feb 24, 12:55 AM
Unknown Object (File)
Sat, Feb 22, 11:13 PM
Subscribers

Details

Summary

Ref T2015. Currently, Drydock has a wait-for-lease workflow which is invoked in the background by the lease workflow.

The goal of this mechanism is to allow bin/drydock lease to print out logs as the lease is acquired. However, this predates the runAllTasksInProcess flags, and they provide a simpler and more robust way (potentially with --trace and PhutilConsole) to do synchronous execution and debug logging.

Simplify this whole mechanism: just run everything in-process in bin/drydock lease, and do logging via --trace. We could thread a PhutilConsole through things too, but this seems good enough for now.

Also various cleanup/etc.

Test Plan

Ran bin/drydock lease. Ran bin/harbormaster build X --plan Y, for Y being a Drydock-dependent build plan.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped