Page MenuHomePhabricator

Modernize Drydock CLI management of task execution
ClosedPublic

Authored by epriestley on Dec 26 2013, 9:03 PM.
Tags
None
Referenced Files
F17535960: D7835.diff
Thu, Jul 3, 10:42 AM
Unknown Object (File)
Tue, Jul 1, 7:04 PM
Unknown Object (File)
Fri, Jun 27, 12:19 PM
Unknown Object (File)
May 26 2025, 1:46 PM
Unknown Object (File)
May 9 2025, 2:38 PM
Unknown Object (File)
May 7 2025, 12:38 AM
Unknown Object (File)
May 6 2025, 7:27 PM
Unknown Object (File)
May 6 2025, 9:58 AM
Subscribers

Details

Summary

Ref T2015. Currently, Drydock has a wait-for-lease workflow which is invoked in the background by the lease workflow.

The goal of this mechanism is to allow bin/drydock lease to print out logs as the lease is acquired. However, this predates the runAllTasksInProcess flags, and they provide a simpler and more robust way (potentially with --trace and PhutilConsole) to do synchronous execution and debug logging.

Simplify this whole mechanism: just run everything in-process in bin/drydock lease, and do logging via --trace. We could thread a PhutilConsole through things too, but this seems good enough for now.

Also various cleanup/etc.

Test Plan

Ran bin/drydock lease. Ran bin/harbormaster build X --plan Y, for Y being a Drydock-dependent build plan.

Diff Detail

Branch
ddock1
Lint
Lint Passed
Unit
Tests Passed