Page MenuHomePhabricator

Modernize Drydock CLI management of task execution
ClosedPublic

Authored by epriestley on Dec 26 2013, 9:03 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, May 1, 11:17 AM
Unknown Object (File)
Sun, Apr 28, 4:15 AM
Unknown Object (File)
Sun, Apr 28, 4:15 AM
Unknown Object (File)
Sun, Apr 28, 4:15 AM
Unknown Object (File)
Sun, Apr 28, 4:15 AM
Unknown Object (File)
Wed, Apr 24, 10:39 PM
Unknown Object (File)
Sat, Apr 20, 6:13 PM
Unknown Object (File)
Thu, Apr 18, 8:53 PM
Subscribers

Details

Summary

Ref T2015. Currently, Drydock has a wait-for-lease workflow which is invoked in the background by the lease workflow.

The goal of this mechanism is to allow bin/drydock lease to print out logs as the lease is acquired. However, this predates the runAllTasksInProcess flags, and they provide a simpler and more robust way (potentially with --trace and PhutilConsole) to do synchronous execution and debug logging.

Simplify this whole mechanism: just run everything in-process in bin/drydock lease, and do logging via --trace. We could thread a PhutilConsole through things too, but this seems good enough for now.

Also various cleanup/etc.

Test Plan

Ran bin/drydock lease. Ran bin/harbormaster build X --plan Y, for Y being a Drydock-dependent build plan.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped