Paths

Table of Contentst

Differential D7773

Use PhutilRope for Channel write buffers and make write buffer details public
ClosedPublic
Actions

Authored by epriestley on Dec 16 2013, 6:30 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Jul 2, 11:33 AM

	Unknown Object (File)
	Sat, Jun 28, 10:47 PM

	Unknown Object (File)
	Sat, Jun 28, 6:04 PM

	Unknown Object (File)
	Sat, Jun 28, 4:38 PM

	Unknown Object (File)
	Fri, Jun 27, 4:32 PM

	Unknown Object (File)
	May 10 2025, 12:52 AM

	Unknown Object (File)
	Apr 20 2025, 5:15 PM

	Unknown Object (File)
	Apr 19 2025, 9:50 PM

Subscribers

Details

Reviewers

Maniphest Tasks

T4241: Cloning repository keeps entire repository in memory as it's being streamed over SSH

Commits

rPHU6eaf191e84e9: Use PhutilRope for Channel write buffers and make write buffer details public

Summary

Ref T4241. Two changes:

Use PhutilRope instead of plain string for the Channel write buffers. This makes it more consistent, and should improve performance in some cases.
Expose information about buffer sizes as public. We need this in a future diff to be able to throttle reads when we're blocked on writes, since we have to be able to test if a write channel is blocked or not.

Test Plan

Ran arc unit. Ran git operations over SSH.

Diff Detail

Branch

readbuffer2

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

btrahan accepted this revision.Dec 16 2013, 6:36 PM

Closed by commit rPHU6eaf191e84e9 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

channel/

PhutilChannel.php

32 lines

PhutilChannelChannel.php

9 lines

PhutilExecChannel.php

8 lines

PhutilSocketChannel.php

1 line

future/

exec/

16 lines

Diff 17580

src/channel/PhutilChannel.php

Loading...

src/channel/PhutilChannelChannel.php

Loading...

src/channel/PhutilExecChannel.php

Loading...

src/channel/PhutilSocketChannel.php

Loading...

src/future/exec/ExecFuture.php

Loading...