Page MenuHomePhabricator

Use PhutilRope for Channel write buffers and make write buffer details public
ClosedPublic

Authored by epriestley on Dec 16 2013, 6:30 PM.
Tags
None
Referenced Files
F19193185: D7773.diff
Tue, Dec 16, 10:43 AM
F19007367: D7773.diff
Nov 21 2025, 7:40 PM
F18987975: D7773.id17589.diff
Nov 17 2025, 11:07 PM
F18856332: D7773.id17589.diff
Nov 1 2025, 9:17 AM
F18852606: D7773.id17589.diff
Oct 31 2025, 10:41 AM
F18807024: D7773.id17580.diff
Oct 18 2025, 10:37 PM
F18619987: D7773.diff
Sep 15 2025, 3:55 AM
F18619983: D7773.diff
Sep 15 2025, 3:55 AM
Subscribers

Details

Summary

Ref T4241. Two changes:

  • Use PhutilRope instead of plain string for the Channel write buffers. This makes it more consistent, and should improve performance in some cases.
  • Expose information about buffer sizes as public. We need this in a future diff to be able to throttle reads when we're blocked on writes, since we have to be able to test if a write channel is blocked or not.
Test Plan

Ran arc unit. Ran git operations over SSH.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped