Page MenuHomePhabricator

Use PhutilRope for Channel write buffers and make write buffer details public
ClosedPublic

Authored by epriestley on Dec 16 2013, 6:30 PM.
Tags
None
Referenced Files
F14442937: D7773.diff
Thu, Dec 26, 9:14 AM
Unknown Object (File)
Fri, Dec 13, 1:20 AM
Unknown Object (File)
Tue, Dec 3, 11:53 AM
Unknown Object (File)
Tue, Dec 3, 10:42 AM
Unknown Object (File)
Tue, Nov 26, 5:13 PM
Unknown Object (File)
Nov 24 2024, 2:35 AM
Unknown Object (File)
Nov 17 2024, 10:17 PM
Unknown Object (File)
Nov 10 2024, 6:15 AM
Subscribers

Details

Summary

Ref T4241. Two changes:

  • Use PhutilRope instead of plain string for the Channel write buffers. This makes it more consistent, and should improve performance in some cases.
  • Expose information about buffer sizes as public. We need this in a future diff to be able to throttle reads when we're blocked on writes, since we have to be able to test if a write channel is blocked or not.
Test Plan

Ran arc unit. Ran git operations over SSH.

Diff Detail

Branch
readbuffer2
Lint
Lint Passed
Unit
Tests Passed