Page MenuHomePhabricator

Fix deletion detection when updating based on ZIP
ClosedPublic

Authored by hach-que on Dec 7 2013, 6:32 AM.
Tags
None
Referenced Files
F13816763: D7736.id17482.diff
Thu, Sep 19, 5:30 PM
F13816752: D7736.id17500.diff
Thu, Sep 19, 5:26 PM
F13814123: D7736.diff
Thu, Sep 19, 3:32 AM
Unknown Object (File)
Wed, Sep 4, 9:45 AM
Unknown Object (File)
Fri, Aug 30, 11:52 PM
Unknown Object (File)
Fri, Aug 23, 4:32 AM
Unknown Object (File)
Fri, Aug 23, 4:32 AM
Unknown Object (File)
Fri, Aug 23, 4:32 AM

Details

Reviewers
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T4205: Implement Phragment
Commits
Restricted Diffusion Commit
rP67b37a5c1dc0: Fix deletion detection when updating based on ZIP
Summary

When the code to update based on ZIP went to look up the child fragments, it explicitly used the paths provided in the ZIP. This meant that we could never detect omissions because there'd never be a scenario where a child fragment would return but not exist in the ZIP. To fix this, the query should be using withLeadingPath instead of withPaths.

Test Plan

Uploaded a ZIP that omitted a file and saw the deleteFile get called (by placing debugging output in the code).

Diff Detail

Branch
fix-delete-detection
Lint
Lint Passed
Unit
No Test Coverage