Cache the computation of the custom block component of the markup key
ClosedPublic
Actions

Authored by epriestley on Nov 13 2013, 11:36 PM.

Tags

None

Referenced Files

	F13263168: D7583.id17119.diff
	Mon, May 27, 7:32 AM

	F13246572: D7583.id17117.diff
	Thu, May 23, 11:36 AM

	F13218948: D7583.id.diff
	Sat, May 18, 2:01 PM

	F13199637: D7583.id17119.diff
	Mon, May 13, 4:31 PM

	F13190397: D7583.id17116.diff
	Sat, May 11, 10:39 AM

	F13180798: D7583.id17123.diff
	Thu, May 9, 4:09 AM

	F13176747: D7583.id17123.diff
	Wed, May 8, 4:46 PM

	Unknown Object (File)
	May 4 2024, 12:51 PM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP3b257381ada0: Cache the computation of the custom block component of the markup key

Summary

Caught this taking way too long on a production profile:

https://secure.phabricator.com/xhprof/profile/PHID-FILE-vfzq3sregh5xvpf5nc2t/?symbol=PhabricatorMarkupEngine::getMarkupFieldKey

Cache it; it's always identical.

Test Plan

Loaded Conpherence locally.

Diff Detail

Branch

perf1

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

Also fix a minor XHProf plugin issue.

Also improve performance of MarkupOneOff

btrahan accepted this revision.Nov 14 2013, 1:06 AM

Closed by commit rP3b257381ada0 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

markup/

PhabricatorMarkupEngine.php

17 lines

Diff 17116

View Options

src/infrastructure/markup/PhabricatorMarkupEngine.php

Cache the computation of the custom block component of the markup keyClosedPublicActions