Page MenuHomePhabricator
Differential D7583

Cache the computation of the custom block component of the markup key
ClosedPublic
Actions

Authored by epriestley on Nov 13 2013, 11:36 PM.
Tags
None
Referenced Files
F18195346: D7583.id17117.diff
Sun, Aug 17, 3:15 PM
F18087800: D7583.id17119.diff
Aug 6 2025, 5:36 AM
F18050961: D7583.id.diff
Aug 3 2025, 9:43 PM
F18031105: D7583.id17116.diff
Aug 2 2025, 11:53 PM
F18002598: D7583.diff
Aug 2 2025, 10:46 AM
Unknown Object (File)
Jun 6 2025, 4:13 PM
Unknown Object (File)
Jun 2 2025, 6:17 PM
Unknown Object (File)
Jun 2 2025, 5:37 AM
View All Files
Subscribers
aran

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rP3b257381ada0: Cache the computation of the custom block component of the markup key
Summary

Caught this taking way too long on a production profile:

https://secure.phabricator.com/xhprof/profile/PHID-FILE-vfzq3sregh5xvpf5nc2t/?symbol=PhabricatorMarkupEngine::getMarkupFieldKey

Cache it; it's always identical.

Test Plan

Loaded Conpherence locally.

Diff Detail

Branch
perf1
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley updated this revision to Unknown Object (????).Nov 13 2013, 11:43 PM

Also fix a minor XHProf plugin issue.

epriestley updated this revision to Unknown Object (????).Nov 14 2013, 12:12 AM

Also improve performance of MarkupOneOff

btrahan accepted this revision.Nov 14 2013, 1:06 AM
epriestley closed this revision.Nov 14 2013, 1:09 AM

Closed by commit rP3b257381ada0 (authored by @epriestley).

Revision Contents
Changeset List

PathSize
src/
aphront/
console/
plugin/
2 lines
infrastructure/
markup/
21 lines
9 lines

Diff 17119

View Options

src/aphront/console/plugin/DarkConsoleXHProfPlugin.php

Loading...
View Options

src/infrastructure/markup/PhabricatorMarkupEngine.php

Loading...
View Options

src/infrastructure/markup/PhabricatorMarkupOneOff.php

Loading...
Phabricator · Built by Phacility