Cache the computation of the custom block component of the markup key
ClosedPublic
Actions

Authored by epriestley on Nov 13 2013, 11:36 PM.

Tags

None

Referenced Files

	F13105034: D7583.diff
	Sat, Apr 27, 2:06 PM

	Unknown Object (File)
	Mon, Apr 22, 5:01 PM

	Unknown Object (File)
	Sat, Mar 30, 8:12 PM

	Unknown Object (File)
	Feb 14 2024, 8:24 AM

	Unknown Object (File)
	Feb 9 2024, 1:44 PM

	Unknown Object (File)
	Jan 22 2024, 9:38 AM

	Unknown Object (File)
	Jan 10 2024, 5:08 PM

	Unknown Object (File)
	Jan 1 2024, 5:17 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP3b257381ada0: Cache the computation of the custom block component of the markup key

Summary

Caught this taking way too long on a production profile:

https://secure.phabricator.com/xhprof/profile/PHID-FILE-vfzq3sregh5xvpf5nc2t/?symbol=PhabricatorMarkupEngine::getMarkupFieldKey

Cache it; it's always identical.

Test Plan

Loaded Conpherence locally.

Diff Detail

Branch

perf1

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

Also fix a minor XHProf plugin issue.

Also improve performance of MarkupOneOff

btrahan accepted this revision.Nov 14 2013, 1:06 AM

Closed by commit rP3b257381ada0 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

markup/

PhabricatorMarkupEngine.php

17 lines

Diff 17116

View Options

src/infrastructure/markup/PhabricatorMarkupEngine.php

Cache the computation of the custom block component of the markup keyClosedPublicActions