Page MenuHomePhabricator

Cache the computation of the custom block component of the markup key
ClosedPublic

Authored by epriestley on Nov 13 2013, 11:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Dec 14, 4:49 PM
Unknown Object (File)
Mon, Dec 9, 6:35 PM
Unknown Object (File)
Sat, Nov 23, 1:59 PM
Unknown Object (File)
Sat, Nov 23, 6:41 AM
Unknown Object (File)
Nov 11 2024, 8:15 PM
Unknown Object (File)
Nov 10 2024, 8:36 PM
Unknown Object (File)
Nov 9 2024, 4:29 AM
Unknown Object (File)
Nov 9 2024, 3:38 AM
Subscribers

Details

Summary

Caught this taking way too long on a production profile:

https://secure.phabricator.com/xhprof/profile/PHID-FILE-vfzq3sregh5xvpf5nc2t/?symbol=PhabricatorMarkupEngine::getMarkupFieldKey

Cache it; it's always identical.

Test Plan

Loaded Conpherence locally.

Diff Detail

Branch
perf1
Lint
Lint Passed
Unit
Tests Passed

Event Timeline

epriestley updated this revision to Unknown Object (????).Nov 13 2013, 11:43 PM

Also fix a minor XHProf plugin issue.

epriestley updated this revision to Unknown Object (????).Nov 14 2013, 12:12 AM

Also improve performance of MarkupOneOff