Cache the computation of the custom block component of the markup key
ClosedPublic
Actions

Authored by epriestley on Nov 13 2013, 11:36 PM.

Tags

None

Referenced Files

	F15506168: D7583.diff
	Tue, Apr 15, 9:04 AM

	F15496946: D7583.id17117.diff
	Sun, Apr 13, 8:57 AM

	F15488880: D7583.id17119.diff
	Fri, Apr 11, 3:53 AM

	F15476753: D7583.id17116.diff
	Mon, Apr 7, 9:06 AM

	F15472475: D7583.diff
	Sat, Apr 5, 1:55 PM

	F15465194: D7583.id17117.diff
	Wed, Apr 2, 3:54 PM

	F15463129: D7583.id.diff
	Tue, Apr 1, 8:37 PM

	F15459188: D7583.diff
	Mon, Mar 31, 10:41 AM

View All Files

Subscribers

aran

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rP3b257381ada0: Cache the computation of the custom block component of the markup key

Summary

Caught this taking way too long on a production profile:

https://secure.phabricator.com/xhprof/profile/PHID-FILE-vfzq3sregh5xvpf5nc2t/?symbol=PhabricatorMarkupEngine::getMarkupFieldKey

Cache it; it's always identical.

Test Plan

Loaded Conpherence locally.

Diff Detail

Branch

perf1

Lint

Lint Passed

Unit

Tests Passed

Event Timeline

Also fix a minor XHProf plugin issue.

Also improve performance of MarkupOneOff

btrahan accepted this revision.Nov 14 2013, 1:06 AM

Closed by commit rP3b257381ada0 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

infrastructure/

markup/

PhabricatorMarkupEngine.php

17 lines

Diff 17116

View Options

src/infrastructure/markup/PhabricatorMarkupEngine.php

Cache the computation of the custom block component of the markup keyClosedPublicActions