Page MenuHomePhabricator

Phriction - make the check for project sub pages more fine-grained
ClosedPublic

Authored by btrahan on Nov 7 2013, 7:47 PM.
Tags
None
Referenced Files
F13228498: D7527.id16975.diff
Mon, May 20, 9:54 AM
F13208584: D7527.id.diff
Thu, May 16, 5:50 PM
F13194336: D7527.diff
Sun, May 12, 9:30 PM
F13177372: D7527.diff
Wed, May 8, 7:40 PM
Unknown Object (File)
Sat, May 4, 2:12 PM
Unknown Object (File)
May 2 2024, 1:28 AM
Unknown Object (File)
Apr 29 2024, 2:47 PM
Unknown Object (File)
Apr 24 2024, 10:15 PM

Details

Summary

we were just checking if projects/ was in the URI before barfing. Use some more fun utility functions such that we only complain if there is no project.

Fixes T4071.

Test Plan

made a subpage under a project - success! tried to make a project wiki page where there was no project - successful failure! tried to make a project wiki sub page where there was no project - successful failure!

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Prefer PhabricatorProjectQuery?

btrahan updated this revision to Unknown Object (????).Nov 7 2013, 8:01 PM

prefer the query class. BONUS - prefer it everywhere this little pattern appears