Page MenuHomePhabricator

Phriction - make the check for project sub pages more fine-grained
ClosedPublic

Authored by btrahan on Nov 7 2013, 7:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mon, Jun 22, 5:25 AM
Unknown Object (File)
Apr 17 2026, 2:54 AM
Unknown Object (File)
Apr 16 2026, 4:30 PM
Unknown Object (File)
Mar 1 2026, 5:58 PM
Unknown Object (File)
Jan 9 2026, 3:34 AM
Unknown Object (File)
Jan 8 2026, 8:22 AM
Unknown Object (File)
Nov 29 2025, 7:48 AM
Unknown Object (File)
Nov 10 2025, 5:07 PM

Details

Summary

we were just checking if projects/ was in the URI before barfing. Use some more fun utility functions such that we only complain if there is no project.

Fixes T4071.

Test Plan

made a subpage under a project - success! tried to make a project wiki page where there was no project - successful failure! tried to make a project wiki sub page where there was no project - successful failure!

Diff Detail

Branch
T4071
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

Prefer PhabricatorProjectQuery?

btrahan updated this revision to Unknown Object (????).Nov 7 2013, 8:01 PM

prefer the query class. BONUS - prefer it everywhere this little pattern appears