Page MenuHomePhabricator

Phriction - make the check for project sub pages more fine-grained
ClosedPublic

Authored by btrahan on Nov 7 2013, 7:47 PM.
Tags
None
Referenced Files
F14657260: D7527.diff
Sat, Jan 11, 8:42 PM
Unknown Object (File)
Tue, Jan 7, 6:48 AM
Unknown Object (File)
Wed, Jan 1, 7:53 PM
Unknown Object (File)
Dec 6 2024, 11:12 AM
Unknown Object (File)
Dec 4 2024, 11:20 AM
Unknown Object (File)
Nov 29 2024, 5:53 PM
Unknown Object (File)
Nov 29 2024, 11:10 AM
Unknown Object (File)
Nov 28 2024, 12:39 AM

Details

Summary

we were just checking if projects/ was in the URI before barfing. Use some more fun utility functions such that we only complain if there is no project.

Fixes T4071.

Test Plan

made a subpage under a project - success! tried to make a project wiki page where there was no project - successful failure! tried to make a project wiki sub page where there was no project - successful failure!

Diff Detail

Branch
T4071
Lint
Lint Passed
Unit
No Test Coverage

Event Timeline

Prefer PhabricatorProjectQuery?

btrahan updated this revision to Unknown Object (????).Nov 7 2013, 8:01 PM

prefer the query class. BONUS - prefer it everywhere this little pattern appears