Page MenuHomePhabricator

Phriction - make the check for project sub pages more fine-grained
ClosedPublic

Authored by btrahan on Nov 7 2013, 7:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Jan 24, 11:28 AM
Unknown Object (File)
Thu, Jan 23, 7:44 AM
Unknown Object (File)
Tue, Jan 21, 6:34 PM
Unknown Object (File)
Fri, Jan 17, 8:35 PM
Unknown Object (File)
Sun, Jan 12, 12:05 AM
Unknown Object (File)
Sat, Jan 11, 8:42 PM
Unknown Object (File)
Tue, Jan 7, 6:48 AM
Unknown Object (File)
Wed, Jan 1, 7:53 PM

Details

Summary

we were just checking if projects/ was in the URI before barfing. Use some more fun utility functions such that we only complain if there is no project.

Fixes T4071.

Test Plan

made a subpage under a project - success! tried to make a project wiki page where there was no project - successful failure! tried to make a project wiki sub page where there was no project - successful failure!

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Prefer PhabricatorProjectQuery?

btrahan updated this revision to Unknown Object (????).Nov 7 2013, 8:01 PM

prefer the query class. BONUS - prefer it everywhere this little pattern appears