Ref T2230. This cleans up D7442, by using git for-each-ref everywhere we can, in a basically reasonable way.
Details
Details
- Reviewers
btrahan avivey - Maniphest Tasks
- Restricted Maniphest Task
- Commits
- Restricted Diffusion Commit
rP3bf372c60c2e: Consolidate querying of things which we can use `git for-each-ref` for
In bare and non-bare repositories:
- Ran discovery with bin/repository discover;
- listed branches on /diffusion/X/;
- listed tags on /diffusion/X/;
- listed tags, branches and refs on /diffusion/rXnnnn.
Diff Detail
Diff Detail
- Branch
- cleanbare
- Lint
Lint Passed - Unit
Tests Passed
Event Timeline
Comment Actions
Some of the offset/count logic was a bit goofy so I simplified that, too.
The overall change here is to get rid of code in this form:
if ($bare) {
$stuff = do_something();
} else {
$stuff = do_something_very_similar();
}...and replace it with code in this form:
$stuff = do_something_query($repository);