Page MenuHomePhabricator

Fix various branch/ref issues with bare repositories in Git
ClosedPublic

Authored by epriestley on Oct 30 2013, 3:39 AM.
Tags
None
Referenced Files
F15467903: D7442.id.diff
Thu, Apr 3, 6:18 PM
F15467902: D7442.diff
Thu, Apr 3, 6:18 PM
F15444184: D7442.id16770.diff
Thu, Mar 27, 8:18 AM
F15438898: D7442.id16770.diff
Wed, Mar 26, 4:27 AM
F15425819: D7442.id.diff
Sun, Mar 23, 6:17 AM
F15404988: D7442.id16766.diff
Tue, Mar 18, 9:54 AM
F15331418: D7442.id16769.diff
Mar 7 2025, 10:15 AM
F15283276: D7442.id16769.diff
Mar 4 2025, 6:32 AM
Subscribers

Details

Reviewers
btrahan
avivey
avive
Maniphest Tasks
Restricted Maniphest Task
Commits
Restricted Diffusion Commit
rP19124554d8b9: Fix various branch/ref issues with bare repositories in Git
Summary

Ref T2230. Although all the non-bare commands run fine in bare repos, not all of them do exactly the same thing.

This could use further cleanup, but at least get it working again for now.

Test Plan

Ran bin/repository pull, bin/repository discover, viewed Diffusion (looked at branch table), viewed a commit (looked at "Branches"), for bare and non-bare git repos.

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

Looks ok to me...

src/applications/repository/storage/PhabricatorRepository.php
793

maybe isWorkingCopyBare()?

epriestley updated this revision to Unknown Object (????).Oct 30 2013, 4:04 AM
  • hasBareWorkingCopy() -> isWorkingCopyBare()