Page MenuHomePhabricator
Differential D14674

Add a button to show the full query from a tabbed dashboard panel
AbandonedPublic
Actions

Authored by epriestley on Dec 4 2015, 10:43 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 1, 7:12 AM
Unknown Object (File)
Sun, Dec 22, 1:12 AM
Unknown Object (File)
Tue, Dec 17, 9:16 PM
Unknown Object (File)
Sat, Dec 14, 2:00 AM
Unknown Object (File)
Tue, Dec 10, 6:57 AM
Unknown Object (File)
Sat, Dec 7, 5:02 AM
Unknown Object (File)
Dec 1 2024, 7:32 AM
Unknown Object (File)
Nov 28 2024, 2:15 AM
View All Files
Subscribers
Korvin

Details

Reviewers
chad
puls
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T9903: Header buttons on dashboard panels are lost when panels are embedded in a tab panel
Summary

Fixes T9903. No idea if this is what you'd want, of course.

Test Plan

Made tabbed and non-tabbed dashboard panels.

Diff Detail

Repository
rP Phabricator
Branch
tabbed-dashboard
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 9295
Build 11035: arc lint + arc unit

Event Timeline

puls updated this revision to Diff 35484.Dec 4 2015, 10:43 PM
puls retitled this revision from to Add a button to show the full query from a tabbed dashboard panel.
puls updated this object.
puls edited the test plan for this revision. (Show Details)
puls added a reviewer: epriestley.
puls added a task: T9903: Header buttons on dashboard panels are lost when panels are embedded in a tab panel.
Herald added reviewers: chad, Blessed Reviewers. · View Herald TranscriptDec 4 2015, 10:43 PM
Herald added a subscriber: Korvin. · View Herald Transcript
chad edited edge metadata.Dec 5 2015, 6:53 PM

Can you post some screenshots?

puls added a comment.Dec 5 2015, 10:34 PM

This just adds a button titled "Full List" in the lower right of the tabbed panel iff there's a limit specified in the query configuration.

Screen Shot 2015-12-05 at 2.33.17 PM.png (700×1 px, 92 KB)

epriestley commandeered this revision.Apr 11 2019, 4:32 PM
epriestley abandoned this revision.
epriestley edited reviewers, added: puls; removed: epriestley.

Obsoleted by changes connected to T9903.

Revision Contents
Changeset List

PathSize
resources/
celerity/
6 lines
src/
applications/
dashboard/
paneltype/
42 lines
webroot/
rsrc/
css/
application/
dashboard/
6 lines

Diff 35484

View Options

resources/celerity/map.php

Loading...
View Options

src/applications/dashboard/paneltype/PhabricatorDashboardQueryPanelType.php

Loading...
View Options

webroot/rsrc/css/application/dashboard/dashboard.css

Loading...
Phabricator · Built by Phacility