Differential D14651

Tailor CLI feedback about "arc alias" to describe shell command aliases
ClosedPublic
Actions

Authored by epriestley on Dec 3 2015, 2:04 PM.

Details

Reviewers

chad

Maniphest Tasks

T9873: arc alias outputs a confusing message when adding a shell command alias

Commits

rARC4a680c762b2e: Tailor CLI feedback about "arc alias" to describe shell command aliases

Summary

Fixes T9873. Instead of printing something like this:

Aliased "arc ls" to "arc !ls".

...print this:

Aliased "arc ls" to shell command "ls".

Test Plan

Added shell commands and internal aliases.
Removed aliases.
Listed aliases.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 35443.Dec 3 2015, 2:04 PM

epriestley retitled this revision from to Tailor CLI feedback about "arc alias" to describe shell command aliases.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T9873: arc alias outputs a confusing message when adding a shell command alias.

chad accepted this revision.Dec 3 2015, 4:27 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Dec 3 2015, 4:27 PM

Closed by commit rARC4a680c762b2e: Tailor CLI feedback about "arc alias" to describe shell command aliases (authored by epriestley, committed by epriestley). · Explain WhyDec 4 2015, 2:31 AM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

workflow/

ArcanistAliasWorkflow.php

143 lines

Diff 35463

View Options

src/workflow/ArcanistAliasWorkflow.php

Tailor CLI feedback about "arc alias" to describe shell command aliasesClosedPublicActions