Page MenuHomePhabricator

Re-open, close, etc. actions not visible
Closed, ResolvedPublic

Description

Re-open, abandon, close, etc. options don't seem to be available as actions on my Differentials. I know that these are features of Phabricator and curious why I can't use them.

Event Timeline

Can you provide more specifics on configuration, screenshots, etc? I've never heard of this.

@chad Do you mean of the project where these aren't visible or a project where these are valid actions?

Does Differential look different than this for you?

pasted_file (156×240 px, 28 KB)

When you scroll to the bottom of a revision page (the URL should look like /D123), you should see something like this:

actions.png (380×1 px, 38 KB)

Are you not seeing that at all, or is it just missing some actions you expect to exist?

On the particular actions you name:

  • "Reopen" is only available if the revision is closed and differential.allow-reopen is set to true in config. If you want this action, you may need to have an administrator adjust configuration. (This option is disabled by default.)
  • "Close" is only available if you are the author and the revision is "Accepted", or differential.always-allow-close is set. (This option is disabled by default.)

Other configuration, like differential.always-allow-abandon and differential.allow-self-accept, also controls the availability of some actions.

Screen Shot 2015-09-21 at 9.56.41 AM.png (160×414 px, 27 KB)

That is on a closed revision

My guess is that differential.allow-reopen is set to false (the default value), which disables the "Reopen" action. If you (or an administrator) change this setting to true in the Config application that should enable the action.

Is there a list of all the flags you could give me? I can't seem to find one

There's no easy way to browse configuration without being an administrator because some configuration may be vaguely sensitive, and some of it depends on other configuration or module availability so we don't (and, broadly, can't, at least in its current form) export it as flat documentation in a text file or HTML or whatever.

The easiest workaround might be to go to https://admin.phacility.com/, use "Launch Test Instance" to start a test instance, then browse to the "Config" application from there. That will let you see what admins see on your install, more or less, and show you all of the config.

There are ~20 options which affect Differential, some of which have nontrivial behavior, and ~200 config options in general, so it's not tremendously practical to just dump a list into this task.

This is the module which defines the Differential-specific options, if that's helpful:

https://secure.phabricator.com/diffusion/P/browse/master/src/applications/differential/config/PhabricatorDifferentialConfigOptions.php

epriestley claimed this task.

Cool. Let us know if you run into anything else.