Page MenuHomePhabricator

Correctly clear draft markers when deleting an inline comment
ClosedPublic

Authored by epriestley on Jul 21 2015, 6:13 PM.
Tags
None
Referenced Files
F14011646: D13665.id33035.diff
Fri, Nov 1, 4:09 AM
F14007583: D13665.id33035.diff
Tue, Oct 29, 8:24 AM
F14002556: D13665.id33035.diff
Fri, Oct 25, 8:04 PM
F14000233: D13665.id33035.diff
Thu, Oct 24, 8:22 PM
F13997661: D13665.diff
Thu, Oct 24, 5:33 AM
F13996077: D13665.id33035.diff
Wed, Oct 23, 5:52 PM
F13977572: D13665.diff
Oct 18 2024, 7:11 PM
F13964386: D13665.id33037.diff
Oct 15 2024, 8:10 PM
Subscribers

Details

Summary

Fixes T8917. Prior to T2618, deleting inlines prompted users, then really deleted the rows.

After T2618, we delete immediately and offer "Undo". However, some interactions with drafts were missed, and we were only clearing the "this revision has a draft" flag on one of the delete pathways (when you delete all the comment text, then save the comment).

Make both the "Delete" action and the "Delete All Comment Text + Save" workflows do the same thing: mark the row as deleted, and clear any relevant drafts.

Test Plan
  • Made an inline comment on a clean revision with no "draft comments" marker in the list view.
  • Used "delete" to delete it.
  • After applying the patch, verified that no "draft commetns" marker appears in the list view.
  • Used Delete and Edit + Remove Text + Save to delete comments in Differential and Diffusion.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Correctly clear draft markers when deleting an inline comment.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
chad added a reviewer: chad.
This revision is now accepted and ready to land.Jul 21 2015, 6:22 PM
This revision was automatically updated to reflect the committed changes.