Page MenuHomePhabricator
Differential D12875

Only revert commits in the same repository
ClosedPublic
Actions

Authored by joshuaspence on May 16 2015, 7:13 AM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jan 28, 11:25 PM
Unknown Object (File)
Mon, Jan 27, 7:11 PM
Unknown Object (File)
Sat, Jan 25, 2:42 AM
Unknown Object (File)
Fri, Jan 24, 4:34 AM
Unknown Object (File)
Fri, Jan 24, 4:34 AM
Unknown Object (File)
Fri, Jan 24, 4:34 AM
Unknown Object (File)
Fri, Jan 24, 4:34 AM
Unknown Object (File)
Tue, Jan 21, 12:41 PM
View All Files
Subscribers
epriestley
Korvin

Details

Reviewers
hach-que
epriestley
Group Reviewers
Blessed Reviewers
Maniphest Tasks
T8215: Revert detection in Diffusion crosses repositories
Commits
Restricted Diffusion Commit
rP79e8d9fc2db1: Only revert commits in the same repository
Summary

Fixes T8215. When adding a revert edge, only consider commits within the same repository.

Test Plan

Imported the arcanist repository three times and inspected the reverts relationships on rARC490984936bb7ddfc589ef3d376ec2ac2365f070d.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

joshuaspence updated this revision to Diff 30965.May 16 2015, 7:13 AM
joshuaspence retitled this revision from to Only revert commits in the same repository.
joshuaspence updated this object.
joshuaspence edited the test plan for this revision. (Show Details)
joshuaspence added reviewers: epriestley, hach-que.
joshuaspence added a task: T8215: Revert detection in Diffusion crosses repositories.
Herald added a reviewer: Blessed Reviewers. · View Herald TranscriptMay 16 2015, 7:13 AM
Herald added subscribers: epriestley, Korvin. · View Herald Transcript
joshuaspence updated this object.May 16 2015, 9:58 AM
joshuaspence edited edge metadata.
epriestley accepted this revision.May 17 2015, 12:54 PM
epriestley edited edge metadata.
This revision is now accepted and ready to land.May 17 2015, 12:54 PM
joshuaspence edited the test plan for this revision. (Show Details)May 17 2015, 11:39 PM
joshuaspence edited edge metadata.
Closed by commit rP79e8d9fc2db1: Only revert commits in the same repository (authored by joshuaspence, committed by joshuaspence). · Explain WhyMay 17 2015, 11:40 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
repository/
worker/
1 line

Diff 31009

View Options

src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php

Loading...
Phabricator · Built by Phacility