Page MenuHomePhabricator
Differential D12441

Implement a rough browse view for tokenizers
ClosedPublic
Actions

Authored by epriestley on Apr 16 2015, 8:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 18, 4:13 AM
Unknown Object (File)
Wed, Dec 11, 12:29 AM
Unknown Object (File)
Thu, Nov 28, 1:11 PM
Unknown Object (File)
Thu, Nov 28, 1:11 PM
Unknown Object (File)
Thu, Nov 28, 10:34 AM
Unknown Object (File)
Thu, Nov 28, 8:43 AM
Unknown Object (File)
Thu, Nov 28, 7:32 AM
Unknown Object (File)
Thu, Nov 28, 7:32 AM
View All Files
Subscribers
epriestley

Details

Reviewers
btrahan
chad
Maniphest Tasks
T5750: Implement typeahead browse mode
Commits
Restricted Diffusion Commit
rPa6416014077f: Implement a rough browse view for tokenizers
Summary

Ref T5750. This adds a basic browse view. Design is a bit rough, see T7841 for some screenshots.

Test Plan

Used browse view to add tokens to tokenizers.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 29857.Apr 16 2015, 8:51 PM
epriestley retitled this revision from to Implement a rough browse view for tokenizers.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
epriestley added a task: T5750: Implement typeahead browse mode.
Herald added a reviewer: chad. · View Herald TranscriptApr 16 2015, 8:51 PM
Herald added a subscriber: epriestley. · View Herald Transcript
chad added inline comments.Apr 16 2015, 8:53 PM
src/view/control/AphrontTokenizerTemplateView.php
84

Why do you have to give it text or it collapses? We have plenty of iconbuttons (like, in inline comments)

epriestley mentioned this in T7841: Improve the design of the tokenizer browse control.Apr 16 2015, 8:54 PM

If I remove the text, I get this:

Screen_Shot_2015-04-16_at_1.54.45_PM.png (159×969 px, 21 KB)

Haven't looked into the details.

epriestley added a comment.Apr 16 2015, 8:56 PM

It looks like inline comments pick up a button height from PHUIButtonBar.

src/view/form/control/AphrontFormTokenizerControl.php
75

asdf

chad edited edge metadata.Apr 16 2015, 9:01 PM

Ah ok, I thought I fixed that back then. I guess I worked around it.

btrahan accepted this revision.Apr 16 2015, 9:18 PM
btrahan edited edge metadata.

shipitquick

This revision is now accepted and ready to land.Apr 16 2015, 9:18 PM
Closed by commit rPa6416014077f: Implement a rough browse view for tokenizers (authored by epriestley, committed by epriestley). · Explain WhyApr 17 2015, 6:08 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
typeahead/
controller/
79 lines
datasource/
10 lines
view/
control/
52 lines
form/
control/
15 lines
webroot/
rsrc/
css/
aphront/
14 lines
13 lines
externals/
javelin/
lib/
control/
tokenizer/
36 lines
js/
application/
typeahead/
2 lines
core/
4 lines

Diff 29883

View Options

src/applications/typeahead/controller/PhabricatorTypeaheadModularDatasourceController.php

Loading...
View Options

src/applications/typeahead/datasource/PhabricatorTypeaheadDatasource.php

Loading...
View Options

src/view/control/AphrontTokenizerTemplateView.php

Loading...
View Options

src/view/form/control/AphrontFormTokenizerControl.php

Loading...
View Options

webroot/rsrc/css/aphront/tokenizer.css

Loading...
View Options

webroot/rsrc/css/aphront/typeahead-browse.css

Loading...
View Options

webroot/rsrc/externals/javelin/lib/control/tokenizer/Tokenizer.js

Loading...
View Options

webroot/rsrc/js/application/typeahead/behavior-typeahead-search.js

Loading...
View Options

webroot/rsrc/js/core/Prefab.js

Loading...
Phabricator · Built by Phacility