Page MenuHomePhabricator
Create Task
Maniphest T7655

Newly created rooms are missing some CSS on initial transactions?
Closed, ResolvedPublic
Actions

Description

To reproduce:

  • Create a room in Conpherence.

Expected:

  • Looks normal.

Actual:

  • Fonts are really weird?
  • Other threads still look normal.

Screen_Shot_2015-03-24_at_1.25.34_PM.png (377×1 px, 44 KB)

But maybe this is expected and non-chat transactions just render super weird?

Revisions and Commits

rP Phabricator
D12148rP4ae28837fde1 Update Conpherence CSS to handle multiple edits better

Related Objects
Search...

Event Timeline

epriestley created this task.Mar 24 2015, 8:27 PM
epriestley raised the priority of this task from to Normal.
epriestley updated the task description. (Show Details)
epriestley added a project: Conpherence.
epriestley added subscribers: epriestley, btrahan, chad.
epriestley added a comment.Mar 24 2015, 8:30 PM

I'm starting to think this is expected. I can get used to it, but my initial reaction was "this looks weird and broken".

btrahan added a comment.Mar 24 2015, 8:35 PM

This might be the "grouped" class that was added / it could be messed up as I had to merge that in on my latest landed stuff.

chad added a comment.Mar 24 2015, 8:45 PM

I don't think I've designed a car with multiple content edited. These don't feel like they add anything to me, but it's easy to fix spacing when multiple are stacked

chad added a comment.Mar 24 2015, 8:45 PM

Case

chad added a comment.Mar 24 2015, 9:09 PM

Is TransactionView only used in Conpherence now?

epriestley added a comment.Mar 24 2015, 9:21 PM

PhabricatorApplicationTransactionView? Used in every application, I think.

chad added a comment.Mar 24 2015, 9:25 PM

Doesn't everything use PHUITimeline for display?

epriestley added a comment.Mar 24 2015, 9:29 PM

PhabricatorApplicationTransactionView sits on top of PHUITimelineView. It just builds/configures a TimelineView when rendered.

chad added a comment.Mar 24 2015, 10:07 PM

I seem to mean PhabricatorTransactionView

chad added a comment.Mar 24 2015, 10:52 PM

I'm roughly here:

pasted_file (521×515 px, 76 KB)

chad added a revision: D12148: Update Conpherence CSS to handle multiple edits better.Mar 24 2015, 11:09 PM
chad closed this task as Resolved by committing rP4ae28837fde1: Update Conpherence CSS to handle multiple edits better.Mar 26 2015, 7:57 PM
chad added a commit: rP4ae28837fde1: Update Conpherence CSS to handle multiple edits better.
Phabricator · Built by Phacility