Paths

Table of Contentst

Differential D12148

Update Conpherence CSS to handle multiple edits better
ClosedPublic
Actions

Authored by chad on Mar 24 2015, 11:09 PM.

Tags

None

Referenced Files

	F15587013: D12148.diff
	Thu, May 8, 9:19 PM

	F15567337: D12148.diff
	Fri, May 2, 5:51 AM

	F15563550: D12148.diff
	Wed, Apr 30, 9:27 AM

	F15559321: D12148.id29259.diff
	Tue, Apr 29, 8:07 AM

	F15556055: D12148.id29206.diff
	Mon, Apr 28, 2:25 PM

	F15518453: D12148.id.diff
	Sat, Apr 19, 1:36 PM

	F15515203: D12148.id29206.diff
	Fri, Apr 18, 8:37 AM

	F15515179: D12148.diff
	Fri, Apr 18, 8:32 AM

Subscribers

Details

Reviewers

epriestley
btrahan

Maniphest Tasks

T7655: Newly created rooms are missing some CSS on initial transactions?

Commits

Restricted Diffusion Commit
rP4ae28837fde1: Update Conpherence CSS to handle multiple edits better

Summary

Fixes T7655. We'll set tighter spacing around edit clusters. Also darkened up the date marker and remove unused phabricator-transaction-view CSS that was still scattered around the site.

Test Plan

Test a full and column multi-edit spam. Visited Ponder and Diffusion, noticed no issues using those apps. Grepped for other users of phabricator-transaction-view

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 29206.Mar 24 2015, 11:09 PM

chad retitled this revision from to Update Conpherence CSS to handle multiple edits better.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added reviewers: epriestley, btrahan.

chad added a task: T7655: Newly created rooms are missing some CSS on initial transactions?.

Herald added subscribers: epriestley, Korvin. · View Herald TranscriptMar 24 2015, 11:09 PM

Works for me!

This revision is now accepted and ready to land.Mar 26 2015, 7:29 PM

Closed by commit rP4ae28837fde1: Update Conpherence CSS to handle multiple edits better (authored by chad, committed by chad). · Explain WhyMar 26 2015, 7:57 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

resources/

celerity/

24 lines

src/

applications/

conpherence/

view/

ConpherenceTransactionView.php

2 lines

diffusion/

controller/

DiffusionCommitController.php

2 lines

view/

layout/

PhabricatorTransactionView.php

4 lines

webroot/

rsrc/

css/

aphront/

transaction.css

8 lines

application/

conpherence/

durable-column.css

14 lines

message-pane.css

26 lines

differential/

revision-comment.css

48 lines

ponder/

20 lines

Diff 29259

resources/celerity/map.php

Loading...

src/applications/conpherence/view/ConpherenceTransactionView.php

Loading...

src/applications/diffusion/controller/DiffusionCommitController.php

Loading...

src/view/layout/PhabricatorTransactionView.php

Loading...

webroot/rsrc/css/aphront/transaction.css

Loading...

webroot/rsrc/css/application/conpherence/durable-column.css

Loading...

webroot/rsrc/css/application/conpherence/message-pane.css

Loading...

webroot/rsrc/css/application/differential/revision-comment.css

Loading...

webroot/rsrc/css/application/ponder/post.css

Loading...