Page MenuHomePhabricator
Create Task
Maniphest T7398

Clicking "Download" on an image, and then right-click Save Image As does not work
Closed, ResolvedPublic
Actions

Description

If you click a thumbnail, and then click "Download" in the bottom right, Chrome shows the file in the browser. If you then right-click Save Image As, it doesn't work because the link is one-time use only, and Chrome shows "Download - Server error".

Right-clicking on the image shown on the preview (after clicking the thumbnail) will download properly.

Screen_Shot_2015-02-27_at_8.31.30_AM.png (210×1 px, 56 KB)

Screen_Shot_2015-02-27_at_8.31.25_AM.png (394×1 px, 50 KB)

Screen_Shot_2015-02-27_at_8.31.01_AM.png (132×532 px, 80 KB)

Revisions and Commits

rP Phabricator
D11915rPed49b41e915d When redirecting to acquire file access tokens, retain 'download' parameter

Event Timeline

hach-que created this task.Feb 27 2015, 10:12 AM
hach-que assigned this task to epriestley.
hach-que raised the priority of this task from to Needs Triage.
hach-que updated the task description. (Show Details)
hach-que added a subscriber: hach-que.
chad updated the task description. (Show Details)Feb 27 2015, 4:32 PM
chad added a project: Files.
epriestley added a comment.Feb 27 2015, 4:33 PM

Clicking "Download" is expected to set Content-Disposition: attachment and force a download. We're probably either pointing the button at the wrong place (likely) or Chrome has gone crazy and no longer permits/recognizes this (unlikely).

epriestley added a comment.Feb 27 2015, 4:34 PM

Yeah, repros in Safari too, we just have the wrong link happening.

joshuaspence added a subscriber: joshuaspence.Feb 28 2015, 3:16 AM
epriestley added a revision: D11915: When redirecting to acquire file access tokens, retain 'download' parameter.Mar 1 2015, 3:55 PM
epriestley triaged this task as Low priority.Mar 1 2015, 3:58 PM
epriestley closed this task as Resolved by committing rPed49b41e915d: When redirecting to acquire file access tokens, retain 'download' parameter.Mar 1 2015, 8:12 PM
epriestley added a commit: rPed49b41e915d: When redirecting to acquire file access tokens, retain 'download' parameter.
Phabricator · Built by Phacility