Page MenuHomePhabricator

When redirecting to acquire file access tokens, retain 'download' parameter
ClosedPublic

Authored by epriestley on Mar 1 2015, 3:55 PM.
Tags
None
Referenced Files
F15427746: D11915.id28712.diff
Sun, Mar 23, 3:53 PM
Unknown Object (File)
Feb 25 2025, 2:57 PM
Unknown Object (File)
Feb 21 2025, 3:44 PM
Unknown Object (File)
Feb 12 2025, 9:36 PM
Unknown Object (File)
Feb 12 2025, 9:36 PM
Unknown Object (File)
Feb 12 2025, 9:34 PM
Unknown Object (File)
Feb 12 2025, 9:24 PM
Unknown Object (File)
Jan 27 2025, 11:30 PM
Subscribers
Tokens
"Piece of Eight" token, awarded by btrahan.

Details

Summary

Fixes T7398. Previously, we would redirect to get a token and then redirect back to make use of it, but lose "download" in the process, and thus not get the correct "Content-Disposition" header.

Test Plan

Clicked "Download" on a lightboxed file.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to When redirecting to acquire file access tokens, retain 'download' parameter.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan awarded a token.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 1 2015, 6:42 PM
This revision was automatically updated to reflect the committed changes.