The Instance Members search engine expects a setInstance call, which it never gets via the dashboard panel framework.
Ideally this query shouldn't be possible to create like this.
Im not sure what I did... but I got this:
>>> UNRECOVERABLE FATAL ERROR <<< Call to a member function getPHID() on a non-object /core/lib/instances/src/applications/instances/query/InstancesMemberSearchEngine.php:35 ┻━┻ ︵ ¯\_(ツ)_/¯ ︵ ┻━┻
| Restricted Differential Revision | Restricted Diffusion Commit | ||
| rP Phabricator | |||
| D11751 | rP6b77dd8e3700 Dashboards - fix optionality of SearchEngines | ||
| D11750 | rPe23351ea3652 Dashboards - introduce ability to optionally allow SearchEngines to be used… | ||
@Mnkras - can you go to https://admin.phacility.com/dashboard/panel/edit/1/ and let me know a bit more about what you made here?
@Mnkras - can you go to https://admin.phacility.com/dashboard/panel/edit/1/ and let me know a bit more about what you made here?
If this is specific to dashboards, we could just add a method to let SearchEngines say "you can't make a dashboard of this", which seems probably reasonable for instance members. This is probably fataling because the Engine requires an Instance to scope it? We could let it operate in instance-free mode but in at least some cases these scoped engines probably don't have a meaningful scopeless mode.
I think we should just uninstall Dashboards on admin.phacility.com anyway.
@Mnkras - you can go to https://admin.phacility.com/dashboard/panel/edit/1/ to clean this up if you want... basically set it to a different panel type and it will not fatal anymore
(Fix was to change how this all works so some panel types can be turned off... Instance Members is the first such panel since it is designed to work in the context of looking at some specific instance and the uber-generic dashboard framework can't set that sort of context.)