Page MenuHomePhabricator

Dashboards - introduce ability to optionally allow SearchEngines to be used as dashboard panels
ClosedPublic

Authored by btrahan on Feb 11 2015, 9:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Oct 9, 7:25 AM
Unknown Object (File)
Tue, Sep 24, 8:42 AM
Unknown Object (File)
Tue, Sep 24, 8:39 AM
Unknown Object (File)
Tue, Sep 24, 8:38 AM
Unknown Object (File)
Tue, Sep 24, 8:36 AM
Unknown Object (File)
Aug 16 2024, 11:45 AM
Unknown Object (File)
Aug 14 2024, 3:45 AM
Unknown Object (File)
Aug 2 2024, 8:15 AM
Subscribers

Details

Summary

Ref T7234. Turns out some search engines are context specific such that they can't be bubbled up to a dashboard panel generically. The example in question is an Instance Members search, where the instance must be specified and is done so in normal codepaths but the dashboard panel stuff has no way of doing that. Ergo, just turn off these sorts of panels.

Note this code just makes it so we can turn off these sorts of panels but does not do any of that.

Test Plan

made sure all the queries still showed up

otherwise, next diff

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Dashboards - introduce ability to optionally allow SearchEngines to be used as dashboard panels.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
epriestley edited edge metadata.
This revision is now accepted and ready to land.Feb 11 2015, 9:43 PM
This revision was automatically updated to reflect the committed changes.